Skip to content

Conversation

@geooo109
Copy link
Collaborator

@geooo109 geooo109 commented Jan 12, 2026

This PR adds parsing/generation support for JSON_KEYS function

Relevant PR: #6662

DOCS
DuckDB
Databricks
Spark
Snowflake
MySQL
Starrocks
Doris
Singlestore

@geooo109 geooo109 marked this pull request as draft January 12, 2026 16:49
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026

SQLGlot Integration Test Results

Comparing:

  • this branch (sqlglot:geooo109/json_keys, sqlglot version: geooo109/json_keys)
  • baseline (main, sqlglot version: 28.5.1.dev96)

⚠️ Limited to dialects: snowflake

By Dialect

dialect main sqlglot:geooo109/json_keys difference links
snowflake -> duckdb 579/847 passed (68.4%) 579/847 passed (68.4%) No change full result / delta
snowflake -> snowflake 847/847 passed (100.0%) 847/847 passed (100.0%) No change full result / delta

Overall

main: 1694 total, 1426 passed (pass rate: 84.2%), sqlglot version: 28.5.1.dev96

sqlglot:geooo109/json_keys: 1694 total, 1426 passed (pass rate: 84.2%), sqlglot version: geooo109/json_keys

Difference: No change

@geooo109
Copy link
Collaborator Author

Will add json path parsing

@geooo109 geooo109 marked this pull request as ready for review January 12, 2026 17:21
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is breaking

@geooo109 geooo109 changed the title feat(parser): add support for JSON_KEYS func feat(parser)!: add support for JSON_KEYS func Jan 12, 2026
@geooo109 geooo109 merged commit 2965077 into main Jan 12, 2026
10 of 11 checks passed
@geooo109 geooo109 deleted the geooo109/json_keys branch January 12, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants